Small code cleanup

manager/config.go

@@ -29,6 +29,7 @@ type FileConfig struct {
 	CACert string `toml:"ca_cert"`
 }
 
+// LoadConfig loads config from specified file
 func LoadConfig(cfgFile string, c *cli.Context) (*Config, error) {
 
 	cfg := new(Config)

manager/db.go

@@ -27,6 +27,7 @@ type dbAdapter interface {
 	Close() error
 }
 
+// interface for a kv database
 type kvAdapter interface {
 	InitBucket(bucket string) error
 	Get(bucket string, key string) ([]byte, error)
@@ -50,8 +51,7 @@ func makeDBAdapter(dbType string, dbFile string) (dbAdapter, error) {
 			return nil, err
 		}
 		db := boltAdapter{
-			db:     innerDB,
-			dbFile: dbFile,
+			db: innerDB,
 		}
 		kv := kvDBAdapter{
 			db: &db,
@@ -77,6 +77,7 @@ func makeDBAdapter(dbType string, dbFile string) (dbAdapter, error) {
 	return nil, fmt.Errorf("unsupported db-type: %s", dbType)
 }
 
+// use the underlying kv database to store data
 type kvDBAdapter struct {
 	db kvAdapter
 }

manager/db_bolt.go

@@ -6,9 +6,9 @@ import (
 	"github.com/boltdb/bolt"
 )
 
+// implement kv interface backed by boltdb
 type boltAdapter struct {
-	db     *bolt.DB
-	dbFile string
+	db *bolt.DB
 }
 
 func (b *boltAdapter) InitBucket(bucket string) (err error) {

manager/db_redis.go

@@ -6,6 +6,7 @@ import (
 	"github.com/go-redis/redis/v8"
 )
 
+// implement kv interface backed by redis
 type redisAdapter struct {
 	db *redis.Client
 }

manager/server.go

@@ -276,7 +276,7 @@ func (s *Manager) updateSchedulesOfWorker(c *gin.Context) {
 		curStatus, err := s.adapter.GetMirrorStatus(workerID, mirrorName)
 		s.rwmu.RUnlock()
 		if err != nil {
-			fmt.Errorf("failed to get job %s of worker %s: %s",
+			err = fmt.Errorf("failed to get job %s of worker %s: %s",
 				mirrorName, workerID, err.Error(),
 			)
 			continue